================
@@ -154,6 +154,16 @@ class CompilerInstanceWithContext {
       IntrusiveRefCntPtr<llvm::vfs::OverlayFileSystem> OverlayFS);
   bool computeDependencies(StringRef ModuleName, DependencyConsumer &Consumer,
                            DependencyActionController &Controller);
+
+  // FIXME: see if we can use a smaller fake buffer, or set the buffer's size
----------------
qiongsiwu wrote:

It bugs me that we have to create a 64k empty string that does not do anything 
else to report correct source locations, hence I added a FIXME so we can review 
in the future when we have better ways to deal with source locations. In the 
grand scheme of things, the cost is not high because the workers share the same 
string. 

The FIXME is removed, and this comment is revised to better indicate that this 
is the limit on the number of queries. 

https://github.com/llvm/llvm-project/pull/183396
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to