================
@@ -1829,6 +1837,13 @@ ModuleLoadResult 
CompilerInstance::findOrCompileModuleAndReadAST(
   Module *M =
       HS.lookupModule(ModuleName, ImportLoc, true, !IsInclusionDirective);
 
+  // Check for any configuration macros that have changed. This is done
+  // immediately before potentially building a module in case this module
+  // depends on having one of its configuration macros defined to successfully
+  // build. If this is not done the user will never see the warning.
+  if (M)
----------------
shafik wrote:

@Bigcheese you added this `nullptr` check here but below `selectModuleSource` 
takes `M` and eventually in `getPrebuiltImplicitModuleFileName` will 
unconditionally dereference the same pointer. 

So either this check is incorrect or this change needed to do more.

https://github.com/llvm/llvm-project/pull/83641
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to