https://github.com/naveen-seth approved this pull request.

These changes make sense to me. 
I think it would be nice if the filename made it clearer that 
`module-includes-%%%%%%%%.input` isn’t a real file on the user’s system, but I 
don’t feel strongly about this.
I approve, but I’d wait for @cyndyishida’s approval as well.

https://github.com/llvm/llvm-project/pull/183396
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to