Icohedron wrote: > Thanks @Icohedron for the review! Have updated the PR. I see it has merge > conflicts, should I rebase?
Good work on the changes! As for the merge conflicts, I would prefer if you made a merge commit to update your branch. I find that rebasing can get messy when you already have changes visible in a PR because rebasing essentially rewrites history. Once the PR is approved we can squash and merge so that the PR merged upstream as one big commit, so there is no need to worry about introducing merge commits upstream :) https://github.com/llvm/llvm-project/pull/177884 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
