ilya-biryukov added a comment. In https://reviews.llvm.org/D37101#851380, @rwols wrote:
> Thanks for the quick review! I'm new to Phabricator and the `arc` CLI tool. > Is the workflow like this: "address a comment, change a few lines, do `arc > diff`, do this multiple times", or is it like this: "address all the > comments, change lots of lines, do `arc diff`, do this once"? Both workflows work, but I would suggest to address a batch of comments before doing `arc diff`, as it may become hard to follow inline comments after multiple `arc diff`s. You can also send multiple commits in a single `arc diff` if you use `git-svn`. I highly suggest looking into that workflow if you're familiar with `git`. There's also an `arc patch` that you can use to apply a patch from this review after doing a new `git-svn` checkout. https://reviews.llvm.org/D37101 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
