================ @@ -0,0 +1,280 @@ +//===----------------------------------------------------------------------===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception +// +//===----------------------------------------------------------------------===// + +#include "MissingEndComparisonCheck.h" +#include "../utils/OptionsUtils.h" +#include "clang/AST/ASTContext.h" +#include "clang/ASTMatchers/ASTMatchFinder.h" +#include "clang/Lex/Lexer.h" +#include "clang/Tooling/FixIt.h" + +using namespace clang::ast_matchers; + +namespace clang::tidy::bugprone { + +namespace { + +constexpr llvm::StringRef IteratorAlgorithms[] = { + "::std::find", "::std::find_if", + "::std::find_if_not", "::std::search", + "::std::search_n", "::std::find_end", + "::std::find_first_of", "::std::lower_bound", + "::std::upper_bound", "::std::partition_point", + "::std::min_element", "::std::max_element", + "::std::adjacent_find", "::std::is_sorted_until"}; + +constexpr llvm::StringRef RangeAlgorithms[] = { + "::std::ranges::find", "::std::ranges::find_if", + "::std::ranges::find_if_not", "::std::ranges::lower_bound", + "::std::ranges::upper_bound", "::std::ranges::min_element", + "::std::ranges::max_element", "::std::ranges::find_first_of", + "::std::ranges::adjacent_find", "::std::ranges::is_sorted_until"}; +} // namespace + +MissingEndComparisonCheck::MissingEndComparisonCheck(StringRef Name, + ClangTidyContext *Context) + : ClangTidyCheck(Name, Context), + ExtraAlgorithms( + utils::options::parseStringList(Options.get("ExtraAlgorithms", ""))) { +} + +void MissingEndComparisonCheck::storeOptions( + ClangTidyOptions::OptionMap &Opts) { + Options.store(Opts, "ExtraAlgorithms", + utils::options::serializeStringList(ExtraAlgorithms)); +} + +static bool isConditionVar(const DeclStmt *S, ASTContext &Ctx) { + const auto &Parents = Ctx.getParents(*S); + if (Parents.empty()) + return false; + + const auto *ParentStmt = Parents[0].get<Stmt>(); + if (!ParentStmt) + return false; + + if (const auto *If = dyn_cast<IfStmt>(ParentStmt)) + return If->getConditionVariableDeclStmt() == S; + if (const auto *While = dyn_cast<WhileStmt>(ParentStmt)) + return While->getConditionVariableDeclStmt() == S; + if (const auto *For = dyn_cast<ForStmt>(ParentStmt)) + return For->getConditionVariableDeclStmt() == S; + + return false; +} + +static std::optional<std::string> ---------------- zeyi2 wrote:
I choose to use `optional` because there are 3 states: - `nullptr`: can't get a valid end point, won't emit a warning - `""`: not safe to give fix-its (e.g. side effects), warning only - `"non-empty"`: fix-its + warning https://github.com/llvm/llvm-project/pull/182543 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
