capitan-davide wrote: Thank you for your feedback. I was not aware about the SSAF project but sounds very interesting, looking forward for it! Now, let me go though some of the comments.
> Exposing this would allow to fill the CTU context cache. And if we didn't > have limits on the size of that cache, it would blow up by recursively > merging all TUs making effectively a unity build. I am no expert about the CTU cache and inlining mechanisms but I was under the impression that `AnalyzerOptions::CTUImportThreshold`? > I would consider accepting this commit upstream only with good concrete > motivation -- e.g. a new checker that requires this to work, provides useful > results and can limit the amount of CTU lookups to ensure acceptable > performance even on huge interconnected projects. I was not intending to contribute checkers at this point as what we have is very project/organization specific. However, I felt this is a somewhat common pattern, and a missing feature of the analyzer. That said I agree, I guess it's better to wait for the new SSAF rather than adding safeguards to the current AST importer. https://github.com/llvm/llvm-project/pull/181713 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
