andykaylor wrote: > > Can you add a test that uses this linkage? > > Added tests for lowering for all the linkage kinds. Thanks for feedback.
Sorry. I wasn't clear. What I was hoping to see was a test case that produced `appending` linkage from C or C++ source code. A quick glance at existing classic codegen test shows that it is only used for compiler-produced variables such as `@llvm.global_ctors` and `@llvm.compiler.used`. We're already producing it when we create `@llvm.global_ctors` in LLVM IR. We represent `global_ctors` as a module attribute, so that won't have a place for this linkage type (which is unfortunate, because we really need to use an appending model when linking modules. Perhaps that should be a global instead. It doesn't look like the test I'm requesting is possible. The lowering test you added is a good substitute. Thanks. https://github.com/llvm/llvm-project/pull/182228 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
