https://github.com/zeyi2 commented:

Here are some improvements I'll address later:

1. Invalid fix-it: `if (int* it2 = std::find(std::begin(arr), std::end(arr), 
2))` -> `(int* (it2 != std::end(arr)) = std::find(std::begin(arr), 
std::end(arr), 2)`
2. See inline comments below
3. add more algorithms like `std::ranges::find_end, std::ranges::find_first_of, 
std::ranges::adjacent_find`
4. Add testcases for loops

Further feedback is appreciated, thanks :)

https://github.com/llvm/llvm-project/pull/182543
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to