ian-twilightcoder wrote: > > Can we do that? I thought > > https://discourse.llvm.org/t/code-review-reminder-about-links-in-code-commit-messages/71847/84 > > said not to. > > It's useful to read further. You can follow that thread to find this snippet > in the developer policy > > > It is also acceptable to add other metadata to the commit message to > > automate processes, including for downstream consumers. This metadata can > > include links to resources that are not available to the entire community. > > However, such links and/or metadata should not be used in place of making > > the commit message self-explanatory. Note that such non-public links should > > not be included in the submitted code. > > https://llvm.org/docs/DeveloperPolicy.html
It's the "to automate processes" part that tripped me up. I didn't understand that might include "humans trying to manually find the Radar fixed by the commit". Fantastic though, I'll start putting Radars in my PRs starting with this one! https://github.com/llvm/llvm-project/pull/181958 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
