felipepiovezan wrote: Sorry, I just landed here without much context. I guess my main feedback is that we're lacking documentation for the problem and the current solution. As someone who doesn't have context trying to understand the problem and the proposed solution, the only path is reading the entire PR (which is fine for reviewing, but probably not for posteriority). Trying to reconcile the PR description -- which is what will be preserved in the git history -- with the current implementation, it seems like they don't match, right? It would be great if we could either update the PR description, or document the design of this somewhere, especially because we're creating a new attribute.
https://github.com/llvm/llvm-project/pull/167666 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
