bwendling wrote: > I've reverted this PR, because it landed without approval. Please do not > reuse old PRs to avoid this kind of confusion, where approvals from a > completely different earlier patch keep hanging around, even though nobody > actually reviewed the new implementation in any detail.
That approval wasn't rescinded, and the new implementation was reviewed by many people, including you, in detail. > Before resubmitting this, I'd recommend creating a PR for the CallBrPrepare > -> InlineAsmPrepare rename first. It looks like the changes end up being > sufficiently substantial that git can no longer recognize this as a file > rename and shows it as a delete + create instead, which makes the diff hard > to review. I TOLD YOU THAT I WOULDN'T BE BEST TO COMBINE THE TWO IN THE INITIAL IMPLEMENTATION! However, you and Nick both insisted that it be done this way. There's literally no reason for me to split the two up, because the renaming is NFC. Please don't move goalposts like this. https://github.com/llvm/llvm-project/pull/92040 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
