JonasToth added a comment.
Did I run it over clang or athletic like that? I would be interested in an
overall output.
I added my thoughts. This check seems very valuable.
================
Comment at: clang-tidy/readability/FunctionCognitiveComplexityCheck.cpp:23
+ // Limit of 25 is the "upstream"'s default.
+ static constexpr const unsigned DefaultLimit = 25U;
+
----------------
Constexpr variables are const as well. I think it's duplicated
================
Comment at: test/clang-tidy/check_clang_tidy.py:76
has_check_messages = input_text.find('CHECK-MESSAGES') >= 0
+ has_check_notes = input_text.find('CHECK-NOTES') >= 0
----------------
Maybe this one in a separate patch?
Repository:
rL LLVM
https://reviews.llvm.org/D36836
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
