ruiu added inline comments.
================
Comment at: llvm/utils/TableGen/OptParserEmitter.cpp:308
const Record &R = *Opts[I];
if (!isa<UnsetInit>(R.getValueInit("ValuesCode"))) {
OS << "{\n";
----------------
You can flip the condition to do early continue.
================
Comment at: llvm/utils/TableGen/OptParserEmitter.cpp:319-320
OS << ", Values);\n";
OS << "(void)ValuesWereAdded;\nassert(ValuesWereAdded &&";
OS << " \"Couldn't add values to OptTable!\");\n";
}
----------------
Can you split the string after each "\n"? It seems the current way of splitting
is somewhat arbitrary.
https://reviews.llvm.org/D36820
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
