https://github.com/zmodem commented:
Thanks for the new PR! I've started making my way through it, but wanted to ask about this one: > Move LateParsedDeclaration and LateParsedAttribute types to DeclSpec.h out of > Parser, so these types can be used in DeclSpec and Declarator and DeclChunk > (forward declaration did not work because these are nested classes of Parser) Would it be possible to make them non-nested classes so they can be forward declared, but keep them in the Parser library? Mainly I'm concerned about the added dependency from AST to Sema (for DeclSpec.h), which doesn't seem right. I guess this allows AST code to inspect the LateParsedAttribute, but is that really needed given that the LateParsedAttrType is transient anyway? https://github.com/llvm/llvm-project/pull/179612 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
