pjaaskel wrote:

> > Reverted the clang-format for that file to fix the nit and rebased.
> 
> Seems CI didn't like it - it's probably best ignore my previous style nit and 
> go with the clang-format suggestion.

I think according to "[but we explicitly do not want patches that do 
large-scale reformatting of existing 
code](https://llvm.org/docs/CodingStandards.html#introduction)", it should be 
OK either way since the code now adheres to the surrounding code and running 
clang-format on the file would touch a lot of files. Of course I can do it if 
wanted that way.

Can someone with commit rights pull this in or suggest what to do with the 
style issue?

https://github.com/llvm/llvm-project/pull/176698
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to