chh commandeered this revision. chh added a reviewer: yawanng. chh added inline comments.
================ Comment at: clang-tidy/android/CloexecAcceptCheck.cpp:42 + "prefer accept4() to accept() because accept4() allows SOCK_CLOEXEC", + /*FixMsg=*/ReplacementText); +} ---------------- alexfh wrote: > Two minor issues here: > 1. `FixMsg` name is misleading, specifically the "Msg" part, since it's not a > message. > 2. there's no need to use an argument comment, where it's clear what the > actual argument's meaning is. E.g. `ReplacementText` is pretty clear on its > own. As is the warning message above. Done. https://reviews.llvm.org/D35362 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
