aaron.ballman added inline comments.
================
Comment at: clang-tidy/cppcoreguidelines/OwningMemoryCheck.cpp:191
+ // Initialization of owners.
+ else if (OwnerInitialization != nullptr) {
+ diag(OwnerInitialization->getLocStart(),
----------------
aaron.ballman wrote:
> No else after a return. Same applies elsewhere.
Please remove the use of `CheckApplied`. The early returns were fine, it's the
complex if/else logic that should be modified. e.g.,
```
if (OwnerAssignment) {
<stuff>
return true;
}
if (OwnerInitialization) {
<stuff>
return true;
}
...
return false;
```
https://reviews.llvm.org/D36354
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
