This revision was automatically updated to reflect the committed changes.
Closed by commit rL310948: [clang] Code cleanup in clang/tooling (authored by
alexshap).
Changed prior to commit:
https://reviews.llvm.org/D36715?vs=111078&id=111229#toc
Repository:
rL LLVM
https://reviews.llvm.org/D36715
Files:
cfe/trunk/include/clang/Tooling/Refactoring/Rename/SymbolName.h
cfe/trunk/lib/Tooling/Refactoring/Rename/RenamingAction.cpp
Index: cfe/trunk/include/clang/Tooling/Refactoring/Rename/SymbolName.h
===================================================================
--- cfe/trunk/include/clang/Tooling/Refactoring/Rename/SymbolName.h
+++ cfe/trunk/include/clang/Tooling/Refactoring/Rename/SymbolName.h
@@ -29,7 +29,7 @@
/// \endcode
class SymbolName {
public:
- SymbolName(StringRef Name) {
+ explicit SymbolName(StringRef Name) {
// While empty symbol names are valid (Objective-C selectors can have empty
// name pieces), occurrences Objective-C selectors are created using an
// array of strings instead of just one string.
Index: cfe/trunk/lib/Tooling/Refactoring/Rename/RenamingAction.cpp
===================================================================
--- cfe/trunk/lib/Tooling/Refactoring/Rename/RenamingAction.cpp
+++ cfe/trunk/lib/Tooling/Refactoring/Rename/RenamingAction.cpp
@@ -53,7 +53,7 @@
}
Changes.push_back(std::move(Change));
}
- return Changes;
+ return std::move(Changes);
}
/// Takes each atomic change and inserts its replacements into the set of
Index: cfe/trunk/include/clang/Tooling/Refactoring/Rename/SymbolName.h
===================================================================
--- cfe/trunk/include/clang/Tooling/Refactoring/Rename/SymbolName.h
+++ cfe/trunk/include/clang/Tooling/Refactoring/Rename/SymbolName.h
@@ -29,7 +29,7 @@
/// \endcode
class SymbolName {
public:
- SymbolName(StringRef Name) {
+ explicit SymbolName(StringRef Name) {
// While empty symbol names are valid (Objective-C selectors can have empty
// name pieces), occurrences Objective-C selectors are created using an
// array of strings instead of just one string.
Index: cfe/trunk/lib/Tooling/Refactoring/Rename/RenamingAction.cpp
===================================================================
--- cfe/trunk/lib/Tooling/Refactoring/Rename/RenamingAction.cpp
+++ cfe/trunk/lib/Tooling/Refactoring/Rename/RenamingAction.cpp
@@ -53,7 +53,7 @@
}
Changes.push_back(std::move(Change));
}
- return Changes;
+ return std::move(Changes);
}
/// Takes each atomic change and inserts its replacements into the set of
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
