yawanng added inline comments.
================ Comment at: clang-tidy/android/CloexecCheck.h:91 + /// Helper function to get the spelling of a particular argument. + StringRef getSpellingArg(const ast_matchers::MatchFinder::MatchResult &Result, + int N) const; ---------------- hokein wrote: > This method seems only be used in one check. Maybe move it to the > implementation of that specific check? And you can make the private members > `FuncBindingStr` and `FuncDeclBindingStr` to protected member. Actually, this method will be used in three checks. https://reviews.llvm.org/D35364 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
