AmrDeveloper wrote: > > Note: You don't need to add the co-author from the clangir when you > > upstream something, > > From https://llvm.org/docs/CodeReview.html#upstreaming-changes-to-llvm: > > > Properly attribute the original changes, e.g., by creating a commit with > > multiple authors ([GitHub > > guide](https://docs.github.com/en/pull-requests/committing-changes-to-your-project/creating-and-editing-commits/creating-a-commit-with-multiple-authors)). > > > you can add the upstream in the title or description :D > > IIUC, that would not be parsed by GitHub the way that `co-authored` will?
IDN if it's the same :D, I realized that when we upstream from the incubator, we don't do that. Thanks for sharing this link. I am not sure if an incubator in LLVM is the same as downstream in this case, but this is an interesting question :D https://github.com/llvm/llvm-project/pull/177576 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
