================
@@ -135,6 +135,9 @@ class TextEncodingConverter {
       return std::string(Result);
     return EC;
   }
+
+  // Maps the encoding name to enum constant if possible.
----------------
s-barannikov wrote:

This looks like exposing an implementation detail. Should we instead add a 
method checking if the conversion is supported?

---
The comment should be doxygen-style (///).

https://github.com/llvm/llvm-project/pull/138895
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to