irishrover wrote: > A low-effort but safe fix would be to always wrap the replacement in > std::string_view(...) (or usage of sv suffix if appropriate). WDYT?
I'd leave it as it is. Because overriding ``std::string_view`` + ``char*`` is a bad pattern anyway. Suffix ""sv is C++20-and-later only. And wrapping with ``std::string_view(...)`` will make the code too noisy IMO. https://github.com/llvm/llvm-project/pull/174288 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
