martell added inline comments.
================
Comment at: lib/Driver/ToolChains/MinGW.cpp:129
+ else if (TC.getArch() == llvm::Triple::aarch64)
+ CmdArgs.push_back("arm64pe");
+ else
----------------
mstorsjo wrote:
> martell wrote:
> > I believe the reason I used thumb2pe for the arm triple is because MS gave
> > us a watered down thumb environment.
> > If I remember correctly there was also an armce environment in binutils
> > called thumbpe because it was thumb 1 mode.
> > Anyway, I assume aarch64 on windows is a fully fledged arm64 environment
> > that doesn't use thumb mode over arm64?
> > I know we don't have any real sdk for this but are you able to tell from
> > link.exe martin?
> > On arm the branch for a dll call would always set the bit for thumb mode in
> > the instruction.
> > Although when I think about it arm64pe is probably the most suitable name
> > anyway because we already use thumb2pe
> >
> There's no thumb mode at all in 64 bit mode (yet at least), so naming it
> thumb* wouldn't make sense. Modelling the previous name after the old thumbpe
> makes sense though.
Great, thanks. Just wanted to clarify because we never had a discussion about
the naming.
LGTM
https://reviews.llvm.org/D36364
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
