https://github.com/RKSimon created https://github.com/llvm/llvm-project/pull/174781
castAs<> will at least assert the cast is valid while getAs<> will always just return nullptr and then explode >From 5af0c27a8a3511a8d4f2bdade6f196adc6c61644 Mon Sep 17 00:00:00 2001 From: Simon Pilgrim <[email protected]> Date: Wed, 7 Jan 2026 14:49:37 +0000 Subject: [PATCH] [ByteCode] InterpBuiltin.cpp - consistently use castAs<> if dereferencing the result castAs<> will at least assert the cast is valid while getAs<> will always just return nullptr and then explode --- clang/lib/AST/ByteCode/InterpBuiltin.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/clang/lib/AST/ByteCode/InterpBuiltin.cpp b/clang/lib/AST/ByteCode/InterpBuiltin.cpp index b4acb786fa90c..3a68ff0e458b4 100644 --- a/clang/lib/AST/ByteCode/InterpBuiltin.cpp +++ b/clang/lib/AST/ByteCode/InterpBuiltin.cpp @@ -148,7 +148,7 @@ static QualType getElemType(const Pointer &P) { if (Desc->isPrimitive()) return T; if (T->isPointerType()) - return T->getAs<PointerType>()->getPointeeType(); + return T->castAs<PointerType>()->getPointeeType(); if (Desc->isArray()) return Desc->getElemQualType(); if (const auto *AT = T->getAsArrayTypeUnsafe()) @@ -2935,7 +2935,7 @@ static bool interp__builtin_select(InterpState &S, CodePtr OpPC, static bool interp__builtin_select_scalar(InterpState &S, const CallExpr *Call) { unsigned N = - Call->getArg(1)->getType()->getAs<VectorType>()->getNumElements(); + Call->getArg(1)->getType()->castAs<VectorType>()->getNumElements(); const Pointer &W = S.Stk.pop<Pointer>(); const Pointer &A = S.Stk.pop<Pointer>(); @@ -5213,7 +5213,7 @@ bool InterpretBuiltin(InterpState &S, CodePtr OpPC, const CallExpr *Call, case X86::BI__builtin_ia32_vperm2f128_si256: case X86::BI__builtin_ia32_permti256: { unsigned NumElements = - Call->getArg(0)->getType()->getAs<VectorType>()->getNumElements(); + Call->getArg(0)->getType()->castAs<VectorType>()->getNumElements(); unsigned PreservedBitsCnt = NumElements >> 2; return interp__builtin_ia32_shuffle_generic( S, OpPC, Call, _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
