ratzdi wrote: Hi @HighCommander4, happy New Year and thank you for your detailed analysis of this PR.
I understand most of your suggestions and find them sensible. What's unclear to me is when the case might occur in FindSymbols, quote "_If we later have multiple requests return a vector<SymbolTag>, it's fine to expose a function that returns a vector<SymbolTag> in AST.h as well.)_"? Is calling `computeSymbolTags` from `SemanticHighlighting` a hypothetical scenario, or do you see adjustments I could make within this PR? https://github.com/llvm/llvm-project/pull/167536 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
