yawanng added inline comments.
================ Comment at: clang-tidy/android/CloexecCheck.h:72 + StringRef getSpellingArg(const ast_matchers::MatchFinder::MatchResult &Result, + int n); + ---------------- hokein wrote: > `n` should be capital `N`. I think we can make it a const member method. And > I can't see any usage of this method in this patch. It's not used in this one, but in others. https://reviews.llvm.org/D35372 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
