qiongsiwu wrote: Note to reviewers:
1. I made a few different attempts to fix the problem, including changing how we compute the suggested predefines (used [here](https://github.com/llvm/llvm-project/blob/7976ac990000a58a7474269a3ca95e16aed8c35b/clang/lib/Frontend/CompilerInstance.cpp#L679)). I attempted changing that so the suggested predefines contains the PCH predefines, but that is not quite right and that duplicates macro definitions from the PCH. 2. Setting the PCH predefines FileID [here](https://github.com/llvm/llvm-project/pull/174034/changes#diff-d8dd6191130efea27aca1a54b23fc45eeeb1cc377147f9d6f5ec8b00ff56fafcR129) is the easiest solution I found, but it may not be the best place to set it. I'd love to get some suggestions if there is a better way to set it. https://github.com/llvm/llvm-project/pull/174034 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
