alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG with one comment.
================
Comment at: clang-tidy/modernize/MakeSmartPtrCheck.cpp:114
- if (Construct)
+ if (Construct && !Construct->getLocation().isMacroID())
checkConstruct(SM, Construct, Type, New);
----------------
Seems to be a bit too broad. Maybe just disable the fix in macros? If warnings
without fixes will be a problem in some codebases, we could then introduce the
`IgnoreMacros` option as in readability-redundant-declaration,
modernize-use-using, modernize-use-bool-literals, and
modernize-use-default-member-init.
https://reviews.llvm.org/D36264
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
