vbvictor wrote:

> > ```diff
> > getArcana
> > ```
> 
> Thanks. Looks like overloaded functions? So let's ignore overloaded functions 
> as I do for virtual/override?

Not always overloaded functions; another case is:

```diff
     // Literals are just printed
-    std::string VisitCXXNullPtrLiteralExpr(const CXXNullPtrLiteralExpr *E) {
+    std::string_view VisitCXXNullPtrLiteralExpr(const CXXNullPtrLiteralExpr 
*E) {
       return "nullptr";
     }
     std::string VisitCXXBoolLiteralExpr(const CXXBoolLiteralExpr *E) {
       return E->getValue() ? "true" : "false";
     }
     std::string VisitIntegerLiteral(const IntegerLiteral *E) {
       return llvm::to_string(E->getValue());
     }
     std::string VisitFloatingLiteral(const FloatingLiteral *E) {
       std::string Result;
       llvm::raw_string_ostream OS(Result);
       E->getValue().print(OS);
       // Printer adds newlines?!
       Result.resize(llvm::StringRef(Result).rtrim().size());
       return Result;
     }
```

So I'd want a generic mechanism to suppress diagnostics without `nolint`

https://github.com/llvm/llvm-project/pull/172170
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to