================
@@ -0,0 +1,67 @@
+//===----------------------------------------------------------------------===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM 
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#include "ReplaceWithStringViewCheck.h"
+#include "clang/ASTMatchers/ASTMatchFinder.h"
+
+using namespace clang::ast_matchers;
+
+namespace clang::tidy::performance {
+
+static llvm::StringLiteral toStringViewTypeStr(StringRef Type) {
+  if (Type.contains("wchar_t"))
----------------
irishrover wrote:

No, `==` is not enough:
```cpp
std::string_view (C++17) | std::basic_string_view<char>
std::wstring_view (C++17) | std::basic_string_view<wchar_t>
std::u8string_view (C++20) | std::basic_string_view<char8_t>
std::u16string_view (C++17) | std::basic_string_view<char16_t>
std::u32string_view (C++17) | std::basic_string_view<char32_t>
```
See https://en.cppreference.com/w/cpp/string/basic_string_view.html

https://github.com/llvm/llvm-project/pull/172170
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to