Endilll wrote:

> Hmm, I kept 9 RUN lines and repeat it for C++23/26, because module/import 
> directive lexical errors may cut-off lexing stage, so multiple module 
> directive in the same file may impact the diagnostics, What do you think?

If repeating 9 RUN lines three times is what needs to be done, I can live with 
that. I'm just a bit worried for maintainability of that test, because 9 RUN 
lines per language mode is much higher than you usual DR test. `-verify-strict` 
is strict enough that I'd merge what can be merged today, and if in the future 
we cut the lexing off more aggressively, the test will fail, so there's no 
compromise on the integrity of the test.

https://github.com/llvm/llvm-project/pull/107168
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to