https://github.com/shafik created 
https://github.com/llvm/llvm-project/pull/172908

Static analysis flagged BuildLockset as not following the Rule of Three, so I 
just added deleted copy ctor and copy assignment.

>From d28c477446e0c303caa4808d179f3a4bd32ac79e Mon Sep 17 00:00:00 2001
From: Shafik Yaghmour <[email protected]>
Date: Thu, 18 Dec 2025 13:18:22 -0800
Subject: [PATCH] [NFC][Clang] Apply Rule of Three to BuildLockset

Static analysis flagged BuildLockset as not following the Rule of Three, so
I just added deleted copy ctor and copy assignment.
---
 clang/lib/Analysis/ThreadSafety.cpp | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/clang/lib/Analysis/ThreadSafety.cpp 
b/clang/lib/Analysis/ThreadSafety.cpp
index c8d61534d0441..60d9c0f3b0ed2 100644
--- a/clang/lib/Analysis/ThreadSafety.cpp
+++ b/clang/lib/Analysis/ThreadSafety.cpp
@@ -1771,6 +1771,8 @@ class BuildLockset : public 
ConstStmtVisitor<BuildLockset> {
   }
 
   ~BuildLockset() { Analyzer->SxBuilder.setLookupLocalVarExpr(nullptr); }
+  BuildLockset(const BuildLockset &) = delete;
+  BuildLockset &operator=(const BuildLockset &) = delete;
 
   void VisitUnaryOperator(const UnaryOperator *UO);
   void VisitBinaryOperator(const BinaryOperator *BO);

_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to