https://github.com/cyndyishida created https://github.com/llvm/llvm-project/pull/172718
None >From 044c43d4af74957397a05e98930f4076dc091669 Mon Sep 17 00:00:00 2001 From: Cyndy Ishida <[email protected]> Date: Wed, 17 Dec 2025 09:47:17 -0800 Subject: [PATCH] [clang] Generalize remaining diagnostics that assume all precompiled files are pchs, NFC --- clang/include/clang/Basic/DiagnosticFrontendKinds.td | 3 +-- clang/lib/Frontend/ASTUnit.cpp | 4 ++-- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/clang/include/clang/Basic/DiagnosticFrontendKinds.td b/clang/include/clang/Basic/DiagnosticFrontendKinds.td index 9e344160ff934..faa3378c07d43 100644 --- a/clang/include/clang/Basic/DiagnosticFrontendKinds.td +++ b/clang/include/clang/Basic/DiagnosticFrontendKinds.td @@ -109,8 +109,7 @@ def err_fe_expected_clang_command : Error< "expected a clang compiler command">; def err_fe_remap_missing_to_file : Error< "could not remap file '%0' to the contents of file '%1'">, DefaultFatal; -def err_fe_unable_to_load_pch : Error< - "unable to load PCH file">; +def err_fe_unable_to_load_ast_file : Error<"unable to load precompiled file">; def err_fe_unable_to_load_plugin : Error< "unable to load plugin '%0': '%1'">; def err_fe_unable_to_create_target : Error< diff --git a/clang/lib/Frontend/ASTUnit.cpp b/clang/lib/Frontend/ASTUnit.cpp index e72317da64596..f350893f56b08 100644 --- a/clang/lib/Frontend/ASTUnit.cpp +++ b/clang/lib/Frontend/ASTUnit.cpp @@ -745,7 +745,7 @@ std::unique_ptr<ASTUnit> ASTUnit::LoadFromASTFile( Filename, TmpFileMgr, *AST->ModCache, PCHContainerRdr, /*FindModuleFileExtensions=*/true, Collector, /*ValidateDiagnosticOptions=*/true, ASTReader::ARR_None)) { - AST->getDiagnostics().Report(diag::err_fe_unable_to_load_pch); + AST->getDiagnostics().Report(diag::err_fe_unable_to_load_ast_file); return nullptr; } @@ -847,7 +847,7 @@ std::unique_ptr<ASTUnit> ASTUnit::LoadFromASTFile( case ASTReader::VersionMismatch: case ASTReader::ConfigurationMismatch: case ASTReader::HadErrors: - AST->getDiagnostics().Report(diag::err_fe_unable_to_load_pch); + AST->getDiagnostics().Report(diag::err_fe_unable_to_load_ast_file); return nullptr; } _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
