klimek added a comment.

Apart from nits, looks OK to me - Eric, are all your concerns addressed?



================
Comment at: include/clang/Tooling/Refactoring/ASTSelection.h:51-53
+  ast_type_traits::DynTypedNode Node;
+  SourceSelectionKind SelectionKind;
+  std::vector<SelectedASTNode> Children;
----------------
As this is a public interface, perhaps we should make them const?


Repository:
  rL LLVM

https://reviews.llvm.org/D35012



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to