vbvictor wrote:

> I prefer "misc-use-string-view" because there is not only one reason to use 
> it.
>
> Doesn't copy underlying string.
Cheap to copy.
Can take both std::string and string literals ("str").

I'm fine with `misc-use-string-view` since we already have 
`misc-use-internal-linkage`. But I have a gut feeling that 
`modernize-use-string-view` would be better because it brings "modernization" 
to the project (improvement in speed, readability, reusability).

-------------------

In clang-tidy docs we have description of misc as "Checks that we didn’t have a 
better category for", so `use-string-view` feels like a modernization check to 
me.

https://github.com/llvm/llvm-project/pull/172170
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to