irishrover wrote: > > Maybe it worth to merge the PR in the current state and then I'll add > > options support and other optimizations as separate commits not to > > overcomplicate this PR? > > Sure, we can go like this. I'll try to re-review it soon. > > For now, could we change check name to `modernize-use-string-view`, WDYT? > > We have this issue #29059 to covert string to string_veiw. And I think > `modernize-use-string-view` check can be easily extended to convert global > `string a = "text"` to `string_view a = "text"`. > > So it's better to give a generic name to cover more cases in the future > rather than having multiple smaller checks.
Yes> sure. So I move the check to modernize-* family (ironically it lived there initially before I submitted it here) and wait for the approvals. https://github.com/llvm/llvm-project/pull/172170 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
