nikic wrote: > > I think tests that the plugin mechanism is working makes sense for all > > tools. > > I agree, but I also agree with nikic that it should only be a smoke test per > tool. The extension points could be just tested with opt. > > That said, could we wait with Clang plugin changes until #171868 is merged? > For Clang, this PR is currently just duplicating efforts.
Right. To be clear, I do think we should have basic tests for the plugin mechanism in all tools, along the lines of what https://github.com/llvm/llvm-project/pull/171868 does. I'm only objecting to testing of pass pipeline hooks being spread across lots of different projects. https://github.com/llvm/llvm-project/pull/172463 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
