timon-ul wrote: Okay, so I think this is a solution I like, I also spent the time refactoring so now we can (hopefully) focus on the small improvements like formatting.
One last question I have is when to use `SmallVector`. The [llvm coding standard](https://llvm.org/docs/CodingStandards.html#c-standard-library) does not really elaborate. I have seen `std::vector` quite a few times so that does not help either. If I take the name as is, I would assume it is for small lists, so maybe the lists of constructors I create might be good candidates, but the `TopLevelDeclarations` might get rather large(?) so maybe not there. https://github.com/llvm/llvm-project/pull/169742 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
