https://github.com/naveen-seth commented:
Overall, I think this is good! In the open PR implementing dependency scanning in the modules driver, we also report all warnings and remarks, but wanted the diagnostics produced during the dependency scan to match the output style of diagnostics emitted directly through the `DiagnosticsEngine` (colors and other formatting), rather than using `TextDiagnosticPrinter`. With this PR, I believe we can do the same for `clang-scan-deps` to further improve the diagnostics output. See: [PR #152770, StandaloneDiagCollector](https://github.com/naveen-seth/llvm-project/blob/223e81cf68cbcb4a9c5e2648e98c0f7199ddb0e2/clang/lib/Driver/ModulesDriver.cpp#L443), [PR #152770, Emitting the diagnostics](https://github.com/naveen-seth/llvm-project/blob/223e81cf68cbcb4a9c5e2648e98c0f7199ddb0e2/clang/lib/Driver/ModulesDriver.cpp#L822-L825) (Since #169599, the `StandaloneDiagnostic` type and related utilities have also been extracted to `clang/include/clang/Frontend/StandaloneDiagnostic.h`.) Doing this might be out of scope for this PR, but I just to share the idea just in case / for future consideration. https://github.com/llvm/llvm-project/pull/172389 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
