timon-ul wrote: Okay so this solution passes the tests, but I am not 100% happy with this implementation. Pushed the code to get some feedback before I spend more time refining this solution.
First off, I do not pass the formatting check, and this is intentional. With this solution I had to move the header `IndexingContext.h` to the include folder, because of this for files like `IndexBody.cpp` want to move it down, but the only functions exposed to the outside are implementations of this header, so I would say this header should stay at the top, right? Is there a way to tell the code formatter this or is this something that just can get merged anyway? Now about the implementation, I did it this way thinking it is the least invasive form of doing so, but I just realized it might also be a neat alternative to instead inherit from `IndexASTConsumer` (so make it not `final` and expose it through the header), then I do not need to move the `IndexingContext.h` to another folder and also can just overwrite the few differences while the rest can stay the same. Unless there is a good reason why we do not want another level of inheritance. https://github.com/llvm/llvm-project/pull/169742 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
