ChuanqiXu9 wrote: > The patch itself looks good. But I like to test it internally before merging. > Hope I can make it in next week.
In our internal workloads, I didn't see noticeable changes in End-to-End compilations. But the good news is all things compile good. So LGTM. > > And also I think it is worthy to add a test for it. We are able to test it > with unittests. e.g., we can test the number of the return decls of > `DeclContext::lookup`, or other similar words. We can add some API for > testing such status too. Would you like to add a test for this? If you don't know how to do, you can look at clang/unittests/Serialization/LoadSpecLazilyTest.cpp for example. This is useful as lit test can't show all things. https://github.com/llvm/llvm-project/pull/171769 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
