Stefan =?utf-8?q?Gränitz?= <[email protected]>, Stefan =?utf-8?q?Gränitz?= <[email protected]>, Stefan =?utf-8?q?Gränitz?= <[email protected]>, Stefan =?utf-8?q?Gränitz?= <[email protected]>, Stefan =?utf-8?q?Gränitz?= <[email protected]>, Stefan =?utf-8?q?Gränitz?= <[email protected]>, Stefan =?utf-8?q?Gränitz?= <[email protected]> Message-ID: In-Reply-To: <llvm.org/llvm/llvm-project/pull/[email protected]>
https://github.com/serge-sans-paille commented: Another round of review, this time with a focus on data management. the Python C API requires a lot of hand-managed memory and you missed some of those, I flagged *some* of them, but not all. I'd suggest, for the sake of maintainability, that you'd use dedicated type to encapsulate the C API to return, for instance, `std::unique_ptr<void*, PyDecRef>` or something along those lines. https://github.com/llvm/llvm-project/pull/171111 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
