bogner wrote:

A few things here:

1. Your description talks about LSB, which usually means "Least Significant 
Byte" IME, but you're clearly talking about "Least Significant Bit" - this 
could be confusing. Please reword for clarity.
2. Are you actually seeing a behaviour difference here, or is this being done 
based just on comparing the emitted DXIL? The actual bit pattern in the status 
uint doesn't seem to have an official definition anywhere as far as I can tell
3. If we're just trying to test the value of a single bit it would be clearer 
to explicitly mask to the bit (`value & 1`) rather than use modulus (`value % 
2`)

https://github.com/llvm/llvm-project/pull/170949
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to