https://github.com/xlauko created https://github.com/llvm/llvm-project/pull/170366
None >From dd936547ddef0ec530562e1ae045f7fe3e853215 Mon Sep 17 00:00:00 2001 From: xlauko <[email protected]> Date: Tue, 2 Dec 2025 22:15:39 +0100 Subject: [PATCH] [CIR] Use default attribute printer/parser (NFC) --- .../include/clang/CIR/Dialect/IR/CIRDialect.td | 9 +-------- clang/lib/CIR/Dialect/IR/CIRAttrs.cpp | 18 ------------------ 2 files changed, 1 insertion(+), 26 deletions(-) diff --git a/clang/include/clang/CIR/Dialect/IR/CIRDialect.td b/clang/include/clang/CIR/Dialect/IR/CIRDialect.td index 34df9af7fc06d..7c38492544b39 100644 --- a/clang/include/clang/CIR/Dialect/IR/CIRDialect.td +++ b/clang/include/clang/CIR/Dialect/IR/CIRDialect.td @@ -24,8 +24,7 @@ def CIR_Dialect : Dialect { let cppNamespace = "::cir"; - let useDefaultAttributePrinterParser = 0; - let useDefaultTypePrinterParser = 0; + let useDefaultAttributePrinterParser = 1; // Enable constant materialization for the CIR dialect. This generates a // declaration for the cir::CIRDialect::materializeConstant function. This @@ -52,12 +51,6 @@ def CIR_Dialect : Dialect { mlir::Type parseType(mlir::DialectAsmParser &parser) const override; void printType(mlir::Type type, mlir::DialectAsmPrinter &printer) const override; - - mlir::Attribute parseAttribute(mlir::DialectAsmParser &parser, - mlir::Type type) const override; - - void printAttribute(mlir::Attribute attr, - mlir::DialectAsmPrinter &os) const override; }]; } diff --git a/clang/lib/CIR/Dialect/IR/CIRAttrs.cpp b/clang/lib/CIR/Dialect/IR/CIRAttrs.cpp index 64ac97025e7c7..ee296f171e0d9 100644 --- a/clang/lib/CIR/Dialect/IR/CIRAttrs.cpp +++ b/clang/lib/CIR/Dialect/IR/CIRAttrs.cpp @@ -68,24 +68,6 @@ using namespace cir; // General CIR parsing / printing //===----------------------------------------------------------------------===// -Attribute CIRDialect::parseAttribute(DialectAsmParser &parser, - Type type) const { - llvm::SMLoc typeLoc = parser.getCurrentLocation(); - llvm::StringRef mnemonic; - Attribute genAttr; - OptionalParseResult parseResult = - generatedAttributeParser(parser, &mnemonic, type, genAttr); - if (parseResult.has_value()) - return genAttr; - parser.emitError(typeLoc, "unknown attribute in CIR dialect"); - return Attribute(); -} - -void CIRDialect::printAttribute(Attribute attr, DialectAsmPrinter &os) const { - if (failed(generatedAttributePrinter(attr, os))) - llvm_unreachable("unexpected CIR type kind"); -} - static void printRecordMembers(mlir::AsmPrinter &printer, mlir::ArrayAttr members) { printer << '{'; _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
