rnkovacs created this revision.
rnkovacs added a project: clang-tools-extra.
Herald added subscribers: whisperity, JDevlieghere.
`bugprone-undefined-memory-manipulation` check crashes on incomplete types.
This diff fixes that by assuming they are `TriviallyCopyable` by default.
https://reviews.llvm.org/D35790
Files:
clang-tidy/bugprone/UndefinedMemoryManipulationCheck.cpp
test/clang-tidy/bugprone-undefined-memory-manipulation.cpp
Index: test/clang-tidy/bugprone-undefined-memory-manipulation.cpp
===================================================================
--- test/clang-tidy/bugprone-undefined-memory-manipulation.cpp
+++ test/clang-tidy/bugprone-undefined-memory-manipulation.cpp
@@ -52,6 +52,13 @@
int vb;
};
+// Incomplete type, assume it is TriviallyCopyable.
+struct NoDef;
+
+void f(NoDef *s) {
+ memset(s, 0, 5);
+}
+
template <typename T>
void memset_temp(T *b) {
memset(b, 0, sizeof(T));
Index: clang-tidy/bugprone/UndefinedMemoryManipulationCheck.cpp
===================================================================
--- clang-tidy/bugprone/UndefinedMemoryManipulationCheck.cpp
+++ clang-tidy/bugprone/UndefinedMemoryManipulationCheck.cpp
@@ -19,7 +19,8 @@
namespace {
AST_MATCHER(CXXRecordDecl, isNotTriviallyCopyable) {
- return !Node.isTriviallyCopyable();
+ // For incomplete types, assume they are TriviallyCopyable.
+ return Node.hasDefinition() ? !Node.isTriviallyCopyable() : false;
}
} // namespace
Index: test/clang-tidy/bugprone-undefined-memory-manipulation.cpp
===================================================================
--- test/clang-tidy/bugprone-undefined-memory-manipulation.cpp
+++ test/clang-tidy/bugprone-undefined-memory-manipulation.cpp
@@ -52,6 +52,13 @@
int vb;
};
+// Incomplete type, assume it is TriviallyCopyable.
+struct NoDef;
+
+void f(NoDef *s) {
+ memset(s, 0, 5);
+}
+
template <typename T>
void memset_temp(T *b) {
memset(b, 0, sizeof(T));
Index: clang-tidy/bugprone/UndefinedMemoryManipulationCheck.cpp
===================================================================
--- clang-tidy/bugprone/UndefinedMemoryManipulationCheck.cpp
+++ clang-tidy/bugprone/UndefinedMemoryManipulationCheck.cpp
@@ -19,7 +19,8 @@
namespace {
AST_MATCHER(CXXRecordDecl, isNotTriviallyCopyable) {
- return !Node.isTriviallyCopyable();
+ // For incomplete types, assume they are TriviallyCopyable.
+ return Node.hasDefinition() ? !Node.isTriviallyCopyable() : false;
}
} // namespace
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
