https://github.com/necto created https://github.com/llvm/llvm-project/pull/170145
This is a tiny change that would make the function contract more clear and our work downstream easier. >From 91aae3a5e3a6e637501a5aa70620b8679d2169d0 Mon Sep 17 00:00:00 2001 From: Arseniy Zaostrovnykh <[email protected]> Date: Mon, 1 Dec 2025 15:18:22 +0100 Subject: [PATCH] [NFC][analyzer] const ptr param in AnalysisConsumer::getModeForDecl This is a tiny change that would make the function contract more clear and our work downstream easier. --- clang/lib/StaticAnalyzer/Frontend/AnalysisConsumer.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/clang/lib/StaticAnalyzer/Frontend/AnalysisConsumer.cpp b/clang/lib/StaticAnalyzer/Frontend/AnalysisConsumer.cpp index e0deec16afb12..7b5dca683d5a7 100644 --- a/clang/lib/StaticAnalyzer/Frontend/AnalysisConsumer.cpp +++ b/clang/lib/StaticAnalyzer/Frontend/AnalysisConsumer.cpp @@ -364,7 +364,7 @@ class AnalysisConsumer : public AnalysisASTConsumer, void storeTopLevelDecls(DeclGroupRef DG); /// Check if we should skip (not analyze) the given function. - AnalysisMode getModeForDecl(Decl *D, AnalysisMode Mode); + AnalysisMode getModeForDecl(const Decl *D, AnalysisMode Mode); void runAnalysisOnTranslationUnit(ASTContext &C); /// Print \p S to stderr if \c Opts.AnalyzerDisplayProgress is set. @@ -677,7 +677,7 @@ void AnalysisConsumer::HandleTranslationUnit(ASTContext &C) { } AnalysisConsumer::AnalysisMode -AnalysisConsumer::getModeForDecl(Decl *D, AnalysisMode Mode) { +AnalysisConsumer::getModeForDecl(const Decl *D, AnalysisMode Mode) { if (!Opts.AnalyzeSpecificFunction.empty() && AnalysisDeclContext::getFunctionName(D) != Opts.AnalyzeSpecificFunction && cross_tu::CrossTranslationUnitContext::getLookupName(D).value_or("") != @@ -695,7 +695,7 @@ AnalysisConsumer::getModeForDecl(Decl *D, AnalysisMode Mode) { const SourceManager &SM = Ctx->getSourceManager(); - const SourceLocation Loc = [&SM](Decl *D) -> SourceLocation { + const SourceLocation Loc = [&SM](const Decl *D) -> SourceLocation { const Stmt *Body = D->getBody(); SourceLocation SL = Body ? Body->getBeginLoc() : D->getLocation(); return SM.getExpansionLoc(SL); _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
