xazax.hun accepted this revision. xazax.hun added a comment. One minor nit, otherwise looks good to me.
================ Comment at: lib/StaticAnalyzer/Core/BugReporter.cpp:3333 + })) { + // Throw-expressions are currently generating sinks during symbolic + // execution: they're not supported yet, and also often used for ---------------- For temporary solutions like this, I prefer to have a FIXME string in the comment. In general, I think it is good to be able to keep track of future tasks by grepping for FIXMEs in the code of the analyzer. https://reviews.llvm.org/D35674 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits