george.burgess.iv added a comment. Thanks for working on this!
One small drive-by nit for you. Same "no need to update the diff this very second" as vsk; I can't LGTM this with confidence. (Also, in the future, please try to include context <https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface> with your patch. Doing so makes reviewing it on Phab much easier. :) ) ================ Comment at: include/clang/Frontend/CodeGenOptions.def:47 ///< aliases to base ctors when possible. +CODEGENOPT(DestroyGlobals, 1, 1) ///< -fdestroy-globals CODEGENOPT(DataSections , 1, 0) ///< Set when -fdata-sections is enabled. ---------------- Nit: Please align the `///` with the above/below ones. https://reviews.llvm.org/D35338 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
