rjmccall added a comment. One minor revision, but otherwise looks great, thank you.
================ Comment at: lib/CodeGen/CodeGenModule.cpp:1166 + if (!IsForDefinition) + getTargetCodeGenInfo().setTargetAttributes(FD, F, *this); + } ---------------- I think you should probably pass IsForDefinition to setTargetAttributes. Targets may want to only set certain attributes on function definitions. Repository: rL LLVM https://reviews.llvm.org/D35479 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
